Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow conversion of AbstractQ to AbstractArray #49424

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Allow conversion of AbstractQ to AbstractArray #49424

merged 1 commit into from
Apr 20, 2023

Conversation

dkarrasch
Copy link
Member

@dkarrasch dkarrasch commented Apr 19, 2023 •
edited
Loading

This small change should allow to convert a AbstractQ object into, say, a CuArray. The difference to the deprecated method right below is that the latter was used to convert the eltype (i.e., convert the backing matrices), but otherwise kept the outer type.

x-ref: JuliaGPU/CUDA.jl#1872

@dkarrasch dkarrasch added the linear algebra Linear algebra label Apr 19, 2023
@dkarrasch dkarrasch mentioned this pull request Apr 19, 2023
Merged
@maleadt
Copy link
Member

maleadt commented Apr 20, 2023

Thanks!

CI failures look unrelated.

@maleadt maleadt merged commit c068048 into master Apr 20, 2023
@maleadt maleadt deleted the dk/abstractq2abstractarray branch April 20, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkarrasch @maleadt